Skip to content

Cherrypicks to aio connector part23a #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2025
Merged

Cherrypicks to aio connector part23a #2602

merged 2 commits into from
Oct 29, 2025

Conversation

@sfc-gh-fpawlowski
Copy link
Contributor

@sfc-gh-fpawlowski sfc-gh-fpawlowski commented Oct 27, 2025 •
edited
Loading

  • SNOW-694457: env-vars-proxy-leaking #2451
    • Applied changes to async - due to differences in how aiohttp works vs urllib3 it was needed to override ClientSession class with custom .request method. For better design and adding the proxy-management overhead only for SnowflakeConnections actually using the proxy (and only once in their timespane) factory was added.

@sfc-gh-fpawlowski sfc-gh-fpawlowski self-assigned this Oct 27, 2025
@sfc-gh-fpawlowski sfc-gh-fpawlowski marked this pull request as ready for review October 27, 2025 18:39
@sfc-gh-fpawlowski
SNOW-694457: env-vars-proxy-leaking (#2451)
c6153e6 
Co-authored-by: Berkay Öztürk <[email protected]>

(cherry picked from commit 87c623e)
@sfc-gh-fpawlowski sfc-gh-fpawlowski force-pushed the cherrypicks-to-aio-connector-part23a branch 2 times, most recently from 75275ce to b167668 Compare October 28, 2025 13:53
@sfc-gh-fpawlowski sfc-gh-fpawlowski force-pushed the cherrypicks-to-aio-connector-part23a branch from b167668 to 647f3af Compare October 28, 2025 14:43
@sfc-gh-fpawlowski sfc-gh-fpawlowski merged commit aa9526b into dev/aio-connector Oct 29, 2025
47 of 54 checks passed
@sfc-gh-fpawlowski sfc-gh-fpawlowski deleted the cherrypicks-to-aio-connector-part23a branch October 29, 2025 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek approved these changes

Assignees

@sfc-gh-fpawlowski sfc-gh-fpawlowski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-fpawlowski @sfc-gh-turbaszek